Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1032263002: Stop deleting ObjectProxy::OnPendingCallIsCompleteData manually (Closed)

Created:
5 years, 9 months ago by hashimoto
Modified:
5 years, 8 months ago
Reviewers:
satorux1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop deleting ObjectProxy::OnPendingCallIsCompleteData manually Instead, let libdbus handle it. This also makes it easier to implement method call cancellation. BUG=471175 Committed: https://crrev.com/9aa653d4ac52f2c89bfa5164a5eddd8164bb9987 Cr-Commit-Position: refs/heads/master@{#322746}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M dbus/object_proxy.cc View 2 chunks +1 line, -2 lines 0 comments Download
M dbus/util.h View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
hashimoto
5 years, 9 months ago (2015-03-26 04:58:59 UTC) #2
satorux1
good catch! LGTM
5 years, 8 months ago (2015-03-30 06:11:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032263002/1
5 years, 8 months ago (2015-03-30 06:12:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-30 06:52:27 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 06:53:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9aa653d4ac52f2c89bfa5164a5eddd8164bb9987
Cr-Commit-Position: refs/heads/master@{#322746}

Powered by Google App Engine
This is Rietveld 408576698