Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1032233002: ozone: evdev: Unsquelch some real errors in release (Closed)

Created:
5 years, 9 months ago by spang
Modified:
5 years, 9 months ago
Reviewers:
kpschoedel
CC:
chromium-reviews, kalyank, tdresser+watch_chromium.org, jdduke+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Unsquelch some real errors in release These are currently DLOG() but we really shouldn't be hiding them. Also use PLOG() when we know errno will be set. BUG=none TEST=build Committed: https://crrev.com/70e0d2d604500f0f46ac07c68720d9caf6399963 Cr-Commit-Position: refs/heads/master@{#322599}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M ui/events/ozone/evdev/event_device_info.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
spang
5 years, 9 months ago (2015-03-25 22:56:19 UTC) #2
kpschoedel
lgtm
5 years, 9 months ago (2015-03-26 14:48:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032233002/1
5 years, 9 months ago (2015-03-26 15:18:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/8916)
5 years, 9 months ago (2015-03-26 15:20:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032233002/1
5 years, 9 months ago (2015-03-27 17:15:40 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-27 17:42:48 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 17:43:44 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70e0d2d604500f0f46ac07c68720d9caf6399963
Cr-Commit-Position: refs/heads/master@{#322599}

Powered by Google App Engine
This is Rietveld 408576698