Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Issue 1032193002: Have compositor_model_bench target near its source files. (Closed)

Created:
5 years, 9 months ago by tfarina
Modified:
5 years, 9 months ago
Reviewers:
Dirk Pranke, no sievers
CC:
chromium-reviews, piman+watch_chromium.org, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Have compositor_model_bench target near its source files. It is more traditional (and recommended) to have GN targets closer to the source files it builds. BUG=432959 TEST=gn gen out-gn && ninja -C out-gn compositor_model_bench R=sievers@chromium.org, dpranke@chromium.org Committed: https://crrev.com/8944e6f2b74d80aba842b29e41de404f1ad2efab Cr-Commit-Position: refs/heads/master@{#322226}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -24 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M gpu/BUILD.gn View 1 chunk +0 lines, -22 lines 0 comments Download
A gpu/tools/compositor_model_bench/BUILD.gn View 1 chunk +28 lines, -0 lines 0 comments Download
M gpu/tools/tools.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
tfarina
Dirk -> https://codereview.chromium.org/1032193002/diff/1/BUILD.gn Daniel -> gpu PTAL
5 years, 9 months ago (2015-03-25 15:59:26 UTC) #2
no sievers
lgtm
5 years, 9 months ago (2015-03-25 16:59:02 UTC) #3
Dirk Pranke
lgtm
5 years, 9 months ago (2015-03-25 17:03:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032193002/1
5 years, 9 months ago (2015-03-25 20:02:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 20:07:09 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 20:08:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8944e6f2b74d80aba842b29e41de404f1ad2efab
Cr-Commit-Position: refs/heads/master@{#322226}

Powered by Google App Engine
This is Rietveld 408576698