Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1032183003: AXObjectCacheImpl::postNotification shouldn't post on an ancestor. (Closed)

Created:
5 years, 9 months ago by dmazzoni
Modified:
5 years, 9 months ago
CC:
blink-reviews, nektarios, dmazzoni, je_julie(Not used), aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

AXObjectCacheImpl::postNotification shouldn't post on an ancestor. This is a code simplification. AXObjectCacheImpl::postNotification doesn't need to post on an ancestor element if the AXObject for the element it's trying to post on doesn't exist. The notification might not make sense on that ancestor element, anyway. If we find something specific that this breaks, we should replace it with an explicit fix instead, rather than relying on this too-broad solution. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192685

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -45 lines) Patch
M Source/modules/accessibility/AXLayoutObject.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/accessibility/AXMenuList.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXMenuListPopup.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/accessibility/AXNodeObject.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/accessibility/AXObjectCacheImpl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXObjectCacheImpl.cpp View 1 5 chunks +7 lines, -34 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dmazzoni
5 years, 9 months ago (2015-03-25 22:03:06 UTC) #2
je_julie(Not used)
I agree with you. lgtm
5 years, 9 months ago (2015-03-27 09:04:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032183003/20001
5 years, 9 months ago (2015-03-27 13:37:32 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-27 16:16:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192685

Powered by Google App Engine
This is Rietveld 408576698