Add a paint filter utility canvas (SkPaintFilterCanvas)

Add a paint filter utility canvas (SkPaintFilterCanvas)

Introduce a paint filter proxy base class as a SkDrawFilter replacement,
and convert SkDebugCanvas to use the new approach.

BUG=skia:3587
R=reed@google.com,mtklein@google.com,robertphillips@google.com,tomhudson@google.com

Committed: https://skia.googlesource.com/skia/+/65cdb57ae8fd23ccec5f7f4f86b34e4aa85c45ae

[f(malita), 2015-03-25 14:13:09]

The plan is to convert other (all?) SkDrawFilter clients, but the CL focuses on
SkDebugCanvas as a starting point.

One API difference is that filterPaint() no longer returns a bool to signal
aborting the draw.  We can add this feature back if needed, but AFAICT nobody is
using it (all clients return true).

[tomhudson, 2015-03-25 14:52:51]

lgtm

https://codereview.chromium.org/1032173002/diff/20001/src/utils/debugger/SkDe...
File src/utils/debugger/SkDebugCanvas.cpp (right):

https://codereview.chromium.org/1032173002/diff/20001/src/utils/debugger/SkDe...
src/utils/debugger/SkDebugCanvas.cpp:71: if (fOverdrawXfermode) {
Is there some reasonable way to be more explicit in this test?

[robertphillips, 2015-03-25 15:07:06]

https://codereview.chromium.org/1032173002/diff/20001/include/utils/SkPaintFi...
File include/utils/SkPaintFilterCanvas.h (right):

https://codereview.chromium.org/1032173002/diff/20001/include/utils/SkPaintFi...
include/utils/SkPaintFilterCanvas.h:46: 
Are we now using "override" instead of "SK_OVERRIDE" ?

https://codereview.chromium.org/1032173002/diff/20001/src/utils/SkPaintFilter...
File src/utils/SkPaintFilterCanvas.cpp (right):

https://codereview.chromium.org/1032173002/diff/20001/src/utils/SkPaintFilter...
src/utils/SkPaintFilterCanvas.cpp:20: 
"const SkPaint&" ?

https://codereview.chromium.org/1032173002/diff/20001/src/utils/SkPaintFilter...
src/utils/SkPaintFilterCanvas.cpp:31:
SkPaintFilterCanvas::SkPaintFilterCanvas(int width, int height)
one line ?

https://codereview.chromium.org/1032173002/diff/20001/src/utils/SkPaintFilter...
src/utils/SkPaintFilterCanvas.cpp:56: const SkPaint& paint) {
Add kDRRect_Type ?

https://codereview.chromium.org/1032173002/diff/20001/src/utils/SkPaintFilter...
src/utils/SkPaintFilterCanvas.cpp:111: const SkPaint& paint) {
Add kVertices_Type ?

https://codereview.chromium.org/1032173002/diff/20001/src/utils/SkPaintFilter...
src/utils/SkPaintFilterCanvas.cpp:119: const SkPaint& paint) {
Add kPatch_Type ?

https://codereview.chromium.org/1032173002/diff/20001/src/utils/debugger/SkDe...
File src/utils/debugger/SkDebugCanvas.cpp (right):

https://codereview.chromium.org/1032173002/diff/20001/src/utils/debugger/SkDe...
src/utils/debugger/SkDebugCanvas.cpp:376: fOverdrawViz = overdrawViz;
this->

https://codereview.chromium.org/1032173002/diff/20001/src/utils/debugger/SkDe...
src/utils/debugger/SkDebugCanvas.cpp:386: fFilterQuality = quality;
this->

[f(malita), 2015-03-25 15:29:23]

https://codereview.chromium.org/1032173002/diff/20001/include/utils/SkPaintFi...
File include/utils/SkPaintFilterCanvas.h (right):

https://codereview.chromium.org/1032173002/diff/20001/include/utils/SkPaintFi...
include/utils/SkPaintFilterCanvas.h:46: 
On 2015/03/25 15:07:06, robertphillips wrote:
> Are we now using "override" instead of "SK_OVERRIDE" ?

That's the word in this corner of the room :)

(mtklein confirmed this should be safe now)

https://codereview.chromium.org/1032173002/diff/20001/src/utils/SkPaintFilter...
File src/utils/SkPaintFilterCanvas.cpp (right):

https://codereview.chromium.org/1032173002/diff/20001/src/utils/SkPaintFilter...
src/utils/SkPaintFilterCanvas.cpp:20: 
On 2015/03/25 15:07:06, robertphillips wrote:
> "const SkPaint&" ?

Done.

https://codereview.chromium.org/1032173002/diff/20001/src/utils/SkPaintFilter...
src/utils/SkPaintFilterCanvas.cpp:31:
SkPaintFilterCanvas::SkPaintFilterCanvas(int width, int height)
On 2015/03/25 15:07:06, robertphillips wrote:
> one line ?

Done.

https://codereview.chromium.org/1032173002/diff/20001/src/utils/SkPaintFilter...
src/utils/SkPaintFilterCanvas.cpp:56: const SkPaint& paint) {
On 2015/03/25 15:07:06, robertphillips wrote:
> Add kDRRect_Type ?

It's a bit unclear to me how useful these types are (most clients don't even pay
attention), but I guess we could go all the way. Done.

https://codereview.chromium.org/1032173002/diff/20001/src/utils/SkPaintFilter...
src/utils/SkPaintFilterCanvas.cpp:111: const SkPaint& paint) {
On 2015/03/25 15:07:06, robertphillips wrote:
> Add kVertices_Type ?

Done.

https://codereview.chromium.org/1032173002/diff/20001/src/utils/SkPaintFilter...
src/utils/SkPaintFilterCanvas.cpp:119: const SkPaint& paint) {
On 2015/03/25 15:07:06, robertphillips wrote:
> Add kPatch_Type ?

Done.

https://codereview.chromium.org/1032173002/diff/20001/src/utils/debugger/SkDe...
File src/utils/debugger/SkDebugCanvas.cpp (right):

https://codereview.chromium.org/1032173002/diff/20001/src/utils/debugger/SkDe...
src/utils/debugger/SkDebugCanvas.cpp:71: if (fOverdrawXfermode) {
On 2015/03/25 14:52:51, tomhudson wrote:
> Is there some reasonable way to be more explicit in this test?

Done.

https://codereview.chromium.org/1032173002/diff/20001/src/utils/debugger/SkDe...
src/utils/debugger/SkDebugCanvas.cpp:376: fOverdrawViz = overdrawViz;
On 2015/03/25 15:07:06, robertphillips wrote:
> this->

Done.

https://codereview.chromium.org/1032173002/diff/20001/src/utils/debugger/SkDe...
src/utils/debugger/SkDebugCanvas.cpp:386: fFilterQuality = quality;
On 2015/03/25 15:07:06, robertphillips wrote:
> this->

Done.

[mtklein, 2015-03-25 15:39:18]

https://codereview.chromium.org/1032173002/diff/20001/include/utils/SkPaintFi...
File include/utils/SkPaintFilterCanvas.h (right):

https://codereview.chromium.org/1032173002/diff/20001/include/utils/SkPaintFi...
include/utils/SkPaintFilterCanvas.h:46: 
On 2015/03/25 15:29:22, f(malita) wrote:
> On 2015/03/25 15:07:06, robertphillips wrote:
> > Are we now using "override" instead of "SK_OVERRIDE" ?
> 
> That's the word in this corner of the room :)
> 
> (mtklein confirmed this should be safe now)

Yes, I am trying to upload the mega s/SK_OVERRIDE/override/g patch now.

[robertphillips, 2015-03-25 15:44:54]

lgtm

[f(malita), 2015-03-25 18:14:27]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2015-03-25 18:14:28]

The patchset sent to the CQ was uploaded after l-g-t-m from tomhudson@google.com
Link to the patchset: https://codereview.chromium.org/1032173002/#ps40001
(title: "review comments")

[commit-bot: I haz the power, 2015-03-25 18:14:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1032173002/40001

[commit-bot: I haz the power, 2015-03-25 18:14:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-25 18:14:58]

Presubmit check for 1032173002-40001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of:
('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org',
'bsalomon@google.com', 'djsollen@chromium.org', 'djsollen@google.com')

[tomhudson, 2015-03-25 20:18:53]

Mike Reed: needs API blessing.

[reed1, 2015-03-25 20:34:40]

https://codereview.chromium.org/1032173002/diff/40001/include/utils/SkPaintFi...
File include/utils/SkPaintFilterCanvas.h (right):

https://codereview.chromium.org/1032173002/diff/40001/include/utils/SkPaintFi...
include/utils/SkPaintFilterCanvas.h:48: virtual void filterPaint(SkPaint* paint,
Type type) const = 0;
nit: onFilterPaint ?

[reed1, 2015-03-25 20:39:17]

Wish I thought there was a clean way to expose/return lazypaint stuff, so that
we don't have to copy the paint for the instances where the subclass didn't need
to change anything... but SkDrawFilter didn't have that efficiency, so oh well.
lgtm.

[f(malita), 2015-03-26 00:37:59]

https://codereview.chromium.org/1032173002/diff/40001/include/utils/SkPaintFi...
File include/utils/SkPaintFilterCanvas.h (right):

https://codereview.chromium.org/1032173002/diff/40001/include/utils/SkPaintFi...
include/utils/SkPaintFilterCanvas.h:48: virtual void filterPaint(SkPaint* paint,
Type type) const = 0;
On 2015/03/25 20:34:40, reed1 wrote:
> nit: onFilterPaint ?

Done.

[f(malita), 2015-03-26 14:15:53]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2015-03-26 14:15:54]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com,
robertphillips@google.com, tomhudson@google.com
Link to the patchset: https://codereview.chromium.org/1032173002/#ps80001
(title: "rebased")

[commit-bot: I haz the power, 2015-03-26 14:16:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1032173002/80001

[commit-bot: I haz the power, 2015-03-26 14:24:51]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/65cdb57ae8fd23ccec5f7f4f86b34e4aa85c45ae