Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1483)

Issue 1032163002: Vector-ICs - speed towards the monomorphic exit as quickly as possible. (Closed)

Created:
5 years, 9 months ago by mvstanton
Modified:
5 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Vector-ICs - speed towards the monomorphic exit as quickly as possible. Thanks to some careful assumptions, we can examine the object found at vector[slot] and trust it's a heap object where the second field is either a map if it's a WeakCell, or definitely not a map if it's a Symbol, String or FixedArray. Use this to save a memory read. BUG= Committed: https://crrev.com/35a67b745d862c5b1f584c2786ebf1369dc4f1ff Cr-Commit-Position: refs/heads/master@{#27631}

Patch Set 1 #

Patch Set 2 : ARM port. #

Patch Set 3 : ARM64 port. #

Patch Set 4 : REBASE. #

Patch Set 5 : Turn off flag. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -195 lines) Patch
M src/arm/assembler-arm.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 2 3 4 8 chunks +54 lines, -68 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 3 4 8 chunks +53 lines, -65 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 4 7 chunks +46 lines, -60 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mvstanton
Hi Toon, Here is the much-discussed perf. optimization to the vector IC dispatcher. Note that ...
5 years, 8 months ago (2015-04-07 12:55:19 UTC) #2
Toon Verwaest
lgtm, don't forget to turn if off.
5 years, 8 months ago (2015-04-07 13:53:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032163002/80001
5 years, 8 months ago (2015-04-07 14:28:56 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 8 months ago (2015-04-07 14:50:04 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 14:50:23 UTC) #8
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/35a67b745d862c5b1f584c2786ebf1369dc4f1ff
Cr-Commit-Position: refs/heads/master@{#27631}

Powered by Google App Engine
This is Rietveld 408576698