Issue 103213007: [PDF] PDF rasterizers fed garbage data in release mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 103213007: [PDF] PDF rasterizers fed garbage data in release mode. (Closed)

Created:
7 years ago by vandebo (ex-Chrome)

Modified:
7 years ago

Reviewers:
epoger

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

[PDF] PDF rasterizers fed garbage data in release mode. BUG=skia:1885 TBR=epoger@google.com Committed: https://code.google.com/p/skia/source/detail?r=12589

Patch Set 1 #

Total comments: 1

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	gm/gmmain.cpp	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/vandebo@chromium.org/103213007/1

7 years ago (2013-12-09 22:41:01 UTC) #1

vandebo (ex-Chrome)

Committed patchset #1 manually as r12589 (presubmit successful).

7 years ago (2013-12-09 23:23:00 UTC) #2

epoger

7 years ago (2013-12-11 17:32:57 UTC) #3

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/103213007/diff/1/gm/gmmain.cpp
File gm/gmmain.cpp (left):

https://codereview.chromium.org/103213007/diff/1/gm/gmmain.cpp#oldcode1079
gm/gmmain.cpp:1079: SkASSERT(documentStream->rewind());
yikes!

Expand Messages | Collapse Messages