Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 1032093004: Use a wrapper for SkDebugf in SkCodec. (Closed)

Created:
5 years, 9 months ago by scroggo
Modified:
5 years, 9 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use a wrapper for SkDebugf in SkCodec. It can be silenced or not with one flag. Always print when building for the android framework. Also remove the meaningless define of override to override. BUG=skia:3257 Committed: https://skia.googlesource.com/skia/+/230d4ac7013f79a3e79efd4452d7fa5c3f508660

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -57 lines) Patch
M gyp/common_conditions.gypi View 1 chunk +1 line, -1 line 0 comments Download
M src/codec/SkCodecPriv.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/codec/SkCodec_libbmp.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/codec/SkCodec_libbmp.cpp View 27 chunks +38 lines, -38 lines 0 comments Download
M src/codec/SkCodec_libico.cpp View 7 chunks +9 lines, -9 lines 0 comments Download
M src/codec/SkCodec_libpng.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M src/codec/SkMasks.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
scroggo
5 years, 9 months ago (2015-03-26 14:10:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032093004/1
5 years, 9 months ago (2015-03-26 14:10:24 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-26 14:10:25 UTC) #5
msarett
lgtm Glad we've got this now!
5 years, 9 months ago (2015-03-26 14:12:25 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 14:15:59 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/230d4ac7013f79a3e79efd4452d7fa5c3f508660

Powered by Google App Engine
This is Rietveld 408576698