Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1032053003: bindings: Add assersion in v8AtomicString (Closed)

Created:
5 years, 9 months ago by bashi
Modified:
5 years, 9 months ago
Reviewers:
haraken, yurys
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

bindings: Add assersion in v8AtomicString We should crash renderers when NewFromUtf8() fails because such failures are critical. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192516

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/bindings/core/v8/V8Binding.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bashi
PTAL?
5 years, 9 months ago (2015-03-25 08:34:22 UTC) #2
haraken
LGTM https://codereview.chromium.org/1032053003/diff/1/Source/bindings/core/v8/V8Binding.h File Source/bindings/core/v8/V8Binding.h (right): https://codereview.chromium.org/1032053003/diff/1/Source/bindings/core/v8/V8Binding.h#newcode356 Source/bindings/core/v8/V8Binding.h:356: RELEASE_ASSERT_NOT_REACHED(); Would you add a comment on this?
5 years, 9 months ago (2015-03-25 08:55:07 UTC) #3
bashi
https://codereview.chromium.org/1032053003/diff/1/Source/bindings/core/v8/V8Binding.h File Source/bindings/core/v8/V8Binding.h (right): https://codereview.chromium.org/1032053003/diff/1/Source/bindings/core/v8/V8Binding.h#newcode356 Source/bindings/core/v8/V8Binding.h:356: RELEASE_ASSERT_NOT_REACHED(); On 2015/03/25 08:55:07, haraken wrote: > > Would ...
5 years, 9 months ago (2015-03-25 09:14:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032053003/20001
5 years, 9 months ago (2015-03-25 10:42:02 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 10:48:13 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192516

Powered by Google App Engine
This is Rietveld 408576698