Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1032033003: Move SharedWorker suppressions inline to worker_browsertest.cc. (Closed)

Created:
5 years, 9 months ago by davidben
Modified:
5 years, 9 months ago
Reviewers:
mmenke
CC:
chromium-reviews, jam, jbudorick+watch_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move SharedWorker suppressions inline to worker_browsertest.cc. This matches WorkerTest.SharedWorkerTlsClientAuth and inline disables make it clearer a subset of the tests don't run on some platforms. BUG=none Committed: https://crrev.com/a3355038d8410634dae6f979ca265b0ba9e2f671 Cr-Commit-Position: refs/heads/master@{#322202}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M build/android/pylib/gtest/filter/content_browsertests_disabled View 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/shared_worker/worker_browsertest.cc View 4 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
davidben
Follow-up cleanup I promised to do a bit ago and never did.
5 years, 9 months ago (2015-03-25 17:15:29 UTC) #2
mmenke
On 2015/03/25 17:15:29, David Benjamin wrote: > Follow-up cleanup I promised to do a bit ...
5 years, 9 months ago (2015-03-25 18:11:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1032033003/1
5 years, 9 months ago (2015-03-25 18:19:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 19:05:36 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 19:06:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a3355038d8410634dae6f979ca265b0ba9e2f671
Cr-Commit-Position: refs/heads/master@{#322202}

Powered by Google App Engine
This is Rietveld 408576698