Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1172)

Issue 1031993003: Upgrade: Add a simple end-to-end test. (Closed)

Created:
5 years, 9 months ago by Mike West
Modified:
5 years, 9 months ago
Reviewers:
Yoav Weiss
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Upgrade: Add a simple end-to-end test. I realized today that I can indeed add some layout tests for UPGRADE, as the port will be left alone if it's non-standard. This patch adds a simple test that verifies that images are upgraded and have the same cross-origin semantics as redirected images. BUG=455674 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192607

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -0 lines) Patch
A LayoutTests/http/tests/security/upgrade-insecure-requests/basic-upgrade.https.html View 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Mike West
Mind taking a look, Yoav?
5 years, 9 months ago (2015-03-26 12:26:05 UTC) #2
Yoav Weiss
On 2015/03/26 12:26:05, Mike West wrote: > Mind taking a look, Yoav? LGTM
5 years, 9 months ago (2015-03-26 14:08:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031993003/1
5 years, 9 months ago (2015-03-26 14:12:00 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 14:15:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192607

Powered by Google App Engine
This is Rietveld 408576698