Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1031943006: Support immersive fullscreen for non-video element (Closed)

Created:
5 years, 9 months ago by qinmin
Modified:
5 years, 8 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support immersive fullscreen for non-video element This change enables immersive mode for non-video element on kitkat+ devices. The behavior is to match that of the video element when going into fullscreen. downstream patch: https://chrome-internal-review.googlesource.com/#/c/210358/ BUG=378412 Committed: https://crrev.com/bb7e68651b6eb2e1f22e04265a50f4521a9350ad Cr-Commit-Position: refs/heads/master@{#323339}

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandler.java View 3 chunks +16 lines, -0 lines 1 comment Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
qinmin
PTAL
5 years, 9 months ago (2015-03-25 21:51:53 UTC) #3
Ted C
lgtm https://codereview.chromium.org/1031943006/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandler.java File chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandler.java (right): https://codereview.chromium.org/1031943006/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandler.java#newcode423 chrome/android/java/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandler.java:423: * Helper method to return extra fullscreen UI ...
5 years, 8 months ago (2015-03-30 22:58:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031943006/20001
5 years, 8 months ago (2015-04-01 21:31:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 8 months ago (2015-04-01 22:19:41 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 22:21:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb7e68651b6eb2e1f22e04265a50f4521a9350ad
Cr-Commit-Position: refs/heads/master@{#323339}

Powered by Google App Engine
This is Rietveld 408576698