Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1031833005: Renaming MinuteMaid to NewGaiaFlow. (Closed)

Created:
5 years, 9 months ago by merkulova
Modified:
5 years, 9 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renaming MinuteMaid to NewGaiaFlow. BUG=0 Committed: https://crrev.com/ffc852c3cb1bf0966cf21fe929c3c74fe1229310 Cr-Commit-Position: refs/heads/master@{#322004}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed from comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -21 lines) Patch
M chrome/browser/resources/chromeos/login/header_bar.js View 1 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 1 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/resources/gaia_auth_host/authenticator.js View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
merkulova
5 years, 9 months ago (2015-03-24 14:27:37 UTC) #2
Nikita (slow)
lgtm https://codereview.chromium.org/1031833005/diff/1/chrome/browser/resources/chromeos/login/header_bar.js File chrome/browser/resources/chromeos/login/header_bar.js (right): https://codereview.chromium.org/1031833005/diff/1/chrome/browser/resources/chromeos/login/header_bar.js#newcode24 chrome/browser/resources/chromeos/login/header_bar.js:24: // Whether new Gaia flow MinuteMaid flow is ...
5 years, 9 months ago (2015-03-24 14:33:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031833005/20001
5 years, 9 months ago (2015-03-24 14:48:20 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-24 15:41:22 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 15:42:21 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ffc852c3cb1bf0966cf21fe929c3c74fe1229310
Cr-Commit-Position: refs/heads/master@{#322004}

Powered by Google App Engine
This is Rietveld 408576698