Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1031833004: Remove allowConnectingInsecureWebSocket Settings item (Closed)

Created:
5 years, 9 months ago by tyoshino (SeeGerritForStatus)
Modified:
5 years, 8 months ago
Reviewers:
Mike West
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove allowConnectingInsecureWebSocket Settings item This CL depends on a Chromium side CL: https://codereview.chromium.org/1032603003/ R=mkwst BUG=367149 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192806

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebase #

Patch Set 4 : Fixed build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -16 lines) Patch
M Source/core/frame/Settings.in View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/loader/MixedContentChecker.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSettingsImpl.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebSettings.h View 1 2 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Mike West
LGTM. Can you add a link to the Chromium-side CL in the patch's description?
5 years, 9 months ago (2015-03-24 12:15:29 UTC) #2
tyoshino (SeeGerritForStatus)
On 2015/03/24 12:15:29, Mike West wrote: > LGTM. > > Can you add a link ...
5 years, 9 months ago (2015-03-25 05:32:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031833004/40001
5 years, 8 months ago (2015-03-31 04:39:52 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_compile_rel/builds/31138)
5 years, 8 months ago (2015-03-31 04:55:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031833004/60001
5 years, 8 months ago (2015-03-31 05:14:11 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 06:40:03 UTC) #12
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192806

Powered by Google App Engine
This is Rietveld 408576698