Issue 1031833003: Fix parameters aggregation.

Issue 1031833003: Fix parameters aggregation. (Closed)

Created:
5 years, 9 months ago by qsr

Modified:
5 years, 9 months ago

Reviewers:
blundell

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix parameters aggregation. R=blundell@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/128ca7dc5f5ae755ca235f4a6b2814e3608a7c3a

Patch Set 2 : Follow review #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -9 lines)			Patch
	M	shell/application_manager/application_manager.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	shell/application_manager/application_manager.cc	View	1	4 chunks	+10 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

blundell

lgtm https://codereview.chromium.org/1031833003/diff/1/shell/application_manager/application_manager.h File shell/application_manager/application_manager.h (right): https://codereview.chromium.org/1031833003/diff/1/shell/application_manager/application_manager.h#newcode148 shell/application_manager/application_manager.h:148: const std::vector<std::string>& previous_parameters); nit: |parameters| makes sense to ...

5 years, 9 months ago (2015-03-24 10:55:22 UTC) #2

qsr

On 2015/03/24 10:55:22, blundell wrote: > lgtm > > https://codereview.chromium.org/1031833003/diff/1/shell/application_manager/application_manager.h > File shell/application_manager/application_manager.h (right): > ...

5 years, 9 months ago (2015-03-24 11:01:04 UTC) #3

qsr

5 years, 9 months ago (2015-03-24 11:02:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
128ca7dc5f5ae755ca235f4a6b2814e3608a7c3a (presubmit successful).

Expand Messages | Collapse Messages