Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1031803004: [turbofan] Remove Instruction::IsControl() and Instruction::MarkAsControl() (Closed)

Created:
5 years, 9 months ago by titzer
Modified:
5 years, 9 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove Instruction::IsControl() and Instruction::MarkAsControl() R=dcarney@chromium.org BUG= Committed: https://crrev.com/9ac4ab799c88eb896831ea25fb4158bd33635e34 Cr-Commit-Position: refs/heads/master@{#27409}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -111 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 7 chunks +10 lines, -17 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 7 chunks +8 lines, -14 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 5 chunks +6 lines, -10 lines 0 comments Download
M src/compiler/instruction.h View 3 chunks +1 line, -9 lines 0 comments Download
M src/compiler/instruction.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 5 chunks +6 lines, -11 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 5 chunks +6 lines, -11 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 4 chunks +5 lines, -9 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 5 chunks +6 lines, -10 lines 0 comments Download
M test/cctest/compiler/test-instruction.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-jump-threading.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/unittests/compiler/instruction-sequence-unittest.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
titzer
5 years, 9 months ago (2015-03-24 13:14:22 UTC) #1
dcarney
lgtm
5 years, 9 months ago (2015-03-24 13:32:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031803004/1
5 years, 9 months ago (2015-03-24 13:35:08 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 14:05:26 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 14:05:46 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ac4ab799c88eb896831ea25fb4158bd33635e34
Cr-Commit-Position: refs/heads/master@{#27409}

Powered by Google App Engine
This is Rietveld 408576698