Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 1031793002: Set the default compiler for X87 to GCC. (Closed)

Created:
5 years, 9 months ago by chunyang.dai
Modified:
5 years, 8 months ago
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Set the default compiler for X87 to GCC. Compiling v8 for X87 platform with clang compiler leads to some test case failure. So we set the default compiler for X87 to GCC. BUG= Committed: https://crrev.com/536b7cf243ce7bfcaffa8627d1c9fceeef1e5664 Cr-Commit-Position: refs/heads/master@{#27706}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/standalone.gypi View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (6 generated)
chunyang.dai
PTAL.
5 years, 8 months ago (2015-04-09 06:18:20 UTC) #3
Weiliang
LGTM, but still need danno&Michael's https://codereview.chromium.org/1031793002/diff/1/build/standalone.gypi File build/standalone.gypi (right): https://codereview.chromium.org/1031793002/diff/1/build/standalone.gypi#newcode151 build/standalone.gypi:151: remove this empty line.
5 years, 8 months ago (2015-04-09 06:55:06 UTC) #4
Michael Achenbach
I'd be happier if the root cause was found why gcc and clang are different ...
5 years, 8 months ago (2015-04-09 07:38:33 UTC) #5
chunyang.dai
Hi, Michael. If we use clang to build Release X87 V8. Two test case failed ...
5 years, 8 months ago (2015-04-09 07:55:36 UTC) #6
Michael Achenbach
I'll set up different compiler/tester bots and move the first to a trusty slave. I'll ...
5 years, 8 months ago (2015-04-09 08:38:03 UTC) #7
Michael Achenbach
This depends on https://codereview.chromium.org/1076723002/ to land and a master restart.
5 years, 8 months ago (2015-04-09 09:14:14 UTC) #8
Michael Achenbach
LGTM - this can land now
5 years, 8 months ago (2015-04-09 13:03:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031793002/40001
5 years, 8 months ago (2015-04-09 13:04:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031793002/40001
5 years, 8 months ago (2015-04-09 13:06:52 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 8 months ago (2015-04-09 13:26:34 UTC) #16
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 13:26:47 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/536b7cf243ce7bfcaffa8627d1c9fceeef1e5664
Cr-Commit-Position: refs/heads/master@{#27706}

Powered by Google App Engine
This is Rietveld 408576698