Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: Source/bindings/core/v8/Dictionary.cpp

Issue 1031783003: Add V8ObjectBuilder helper and use in modules/crypto/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: use "const String&" Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/Dictionary.h ('k') | Source/bindings/core/v8/V8ObjectBuilder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/Dictionary.cpp
diff --git a/Source/bindings/core/v8/Dictionary.cpp b/Source/bindings/core/v8/Dictionary.cpp
index 612ee812f54111df885ec078011804695f2ae607..05fe43e352b69434967c337dabad318385e361c7 100644
--- a/Source/bindings/core/v8/Dictionary.cpp
+++ b/Source/bindings/core/v8/Dictionary.cpp
@@ -93,11 +93,6 @@ Dictionary& Dictionary::operator=(const Dictionary& optionsObject)
return *this;
}
-Dictionary Dictionary::createEmpty(v8::Isolate* isolate)
-{
- return Dictionary(v8::Object::New(isolate), isolate, emptyExceptionState());
-}
-
bool Dictionary::isObject() const
{
return !isUndefinedOrNull() && m_options->IsObject();
@@ -161,32 +156,6 @@ bool Dictionary::get(const String& key, Dictionary& value) const
return true;
}
-bool Dictionary::set(const String& key, const v8::Handle<v8::Value>& value)
-{
- if (isUndefinedOrNull())
- return false;
- v8::Local<v8::Object> options = m_options->ToObject(m_isolate);
- ASSERT(!options.IsEmpty());
- ASSERT(m_exceptionState);
-
- return options->Set(v8String(m_isolate, key), value);
-}
-
-bool Dictionary::set(const String& key, const String& value)
-{
- return set(key, v8String(m_isolate, value));
-}
-
-bool Dictionary::set(const String& key, unsigned value)
-{
- return set(key, v8::Integer::NewFromUnsigned(m_isolate, value));
-}
-
-bool Dictionary::set(const String& key, const Dictionary& value)
-{
- return set(key, value.v8Value());
-}
-
bool Dictionary::convert(ConversionContext& context, const String& key, Dictionary& value) const
{
ConversionContextScope scope(context);
« no previous file with comments | « Source/bindings/core/v8/Dictionary.h ('k') | Source/bindings/core/v8/V8ObjectBuilder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698