Source/core/editing/MarkupAccumulator.h - Issue 1031783002: Escape '&' in javascript URLs for innerHTML/outerHTML

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/MarkupAccumulator.h

Issue 1031783002: Escape '&' in javascript URLs for innerHTML/outerHTML (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/innerHTML/javascript-url.html ('K') | « LayoutTests/fast/innerHTML/javascript-url-expected.txt ('k') | Source/core/editing/MarkupAccumulator.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/MarkupAccumulator.h

diff --git a/Source/core/editing/MarkupAccumulator.h b/Source/core/editing/MarkupAccumulator.h

index fc578947568af0d88a17e97dab5c65cf88771130..de94726e23ee065de54680349c4e08cf519c3167 100644

--- a/Source/core/editing/MarkupAccumulator.h

+++ b/Source/core/editing/MarkupAccumulator.h

@@ -118,7 +118,7 @@ protected:

private:

String resolveURLIfNeeded(const Element&, const String&) const;

- void appendQuotedURLAttributeValue(StringBuilder&, const Element&, const Attribute&);

+ void appendHTMLEscapedURLAttributeValue(StringBuilder&, const Element&, const Attribute&);

fs 2015/03/24 10:20:11 I think you should keep the old name - the convers

Abhijeet Kandalkar Slow 2015/03/24 14:20:36 Done.

void serializeNodesWithNamespaces(Node& targetNode, EChildrenOnly, const Namespaces*);

bool serializeAsHTMLDocument(const Node&) const;