Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1031783002: Escape '&' in javascript URLs for innerHTML/outerHTML (Closed)

Created:
5 years, 9 months ago by Abhijeet Kandalkar Slow
Modified:
5 years, 9 months ago
Reviewers:
vivekg, hraken, fs
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Escape '&' in javascript URLs for innerHTML/outerHTML Special handling with minimal HTML escape when serializing URL is already implemented for quote. Added implementation to replace '&' by '&'. Try to match FF. BUG=469298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192539

Patch Set 1 #

Total comments: 10

Patch Set 2 : #

Total comments: 5

Patch Set 3 : #

Patch Set 4 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -67 lines) Patch
M LayoutTests/fast/innerHTML/javascript-url.html View 1 2 3 1 chunk +24 lines, -55 lines 0 comments Download
M LayoutTests/fast/innerHTML/javascript-url-expected.txt View 1 2 3 1 chunk +11 lines, -12 lines 0 comments Download
M Source/core/editing/MarkupAccumulator.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
Abhijeet Kandalkar Slow
Please review patch.
5 years, 9 months ago (2015-03-24 07:22:45 UTC) #2
fs
Should the reviewer "hraken" you added have been haraken? https://codereview.chromium.org/1031783002/diff/1/LayoutTests/fast/innerHTML/javascript-url.html File LayoutTests/fast/innerHTML/javascript-url.html (right): https://codereview.chromium.org/1031783002/diff/1/LayoutTests/fast/innerHTML/javascript-url.html#newcode2 LayoutTests/fast/innerHTML/javascript-url.html:2: ...
5 years, 9 months ago (2015-03-24 10:20:12 UTC) #3
Abhijeet Kandalkar Slow
Incorporated review comments. Please review updated patch. Thnaks!! https://codereview.chromium.org/1031783002/diff/1/LayoutTests/fast/innerHTML/javascript-url.html File LayoutTests/fast/innerHTML/javascript-url.html (right): https://codereview.chromium.org/1031783002/diff/1/LayoutTests/fast/innerHTML/javascript-url.html#newcode2 LayoutTests/fast/innerHTML/javascript-url.html:2: <head> ...
5 years, 9 months ago (2015-03-24 14:20:36 UTC) #4
fs
> Escape javascript href attributes properly for innerHTML/outerHTML Please rephrase this to make it more ...
5 years, 9 months ago (2015-03-24 14:39:01 UTC) #5
Abhijeet Kandalkar Slow
Please review updated patch. https://codereview.chromium.org/1031783002/diff/20001/LayoutTests/fast/innerHTML/javascript-url.html File LayoutTests/fast/innerHTML/javascript-url.html (right): https://codereview.chromium.org/1031783002/diff/20001/LayoutTests/fast/innerHTML/javascript-url.html#newcode24 LayoutTests/fast/innerHTML/javascript-url.html:24: shouldBeEqualToString("r.firstChild.outerHTML", '<a href="javascript:window.location=\'?x&amp;y\'">link</a>'); On 2015/03/24 ...
5 years, 9 months ago (2015-03-25 11:22:16 UTC) #6
fs
lgtm https://codereview.chromium.org/1031783002/diff/20001/LayoutTests/fast/innerHTML/javascript-url.html File LayoutTests/fast/innerHTML/javascript-url.html (right): https://codereview.chromium.org/1031783002/diff/20001/LayoutTests/fast/innerHTML/javascript-url.html#newcode24 LayoutTests/fast/innerHTML/javascript-url.html:24: shouldBeEqualToString("r.firstChild.outerHTML", '<a href="javascript:window.location=\'?x&amp;y\'">link</a>'); On 2015/03/25 11:22:16, Abhijeet Kandalkar ...
5 years, 9 months ago (2015-03-25 11:55:26 UTC) #7
Abhijeet Kandalkar Slow
On 2015/03/25 11:55:26, fs wrote: > lgtm > > https://codereview.chromium.org/1031783002/diff/20001/LayoutTests/fast/innerHTML/javascript-url.html > File LayoutTests/fast/innerHTML/javascript-url.html (right): > ...
5 years, 9 months ago (2015-03-25 12:20:57 UTC) #8
fs
On 2015/03/25 12:20:57, Abhijeet Kandalkar wrote: > On 2015/03/25 11:55:26, fs wrote: > > lgtm ...
5 years, 9 months ago (2015-03-25 12:30:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031783002/60001
5 years, 9 months ago (2015-03-25 12:36:12 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 14:08:33 UTC) #12
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192539

Powered by Google App Engine
This is Rietveld 408576698