Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2653)

Issue 10317021: [Chromoting] Move SharedSecretHash from Me2MeHostAuthenticatorFactory to AuthenticationMethod. (Closed)

Created:
8 years, 4 months ago by simonmorris
Modified:
8 years, 4 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

[Chromoting] Move SharedSecretHash from Me2MeHostAuthenticatorFactory to AuthenticationMethod. This reduces the size of remoting_host_controller.exe, which depends on SharedSecretHash. BUG=126256 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135522

Patch Set 1 #

Patch Set 2 : Sync. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -32 lines) Patch
M remoting/protocol/authentication_method.h View 1 chunk +11 lines, -0 lines 0 comments Download
M remoting/protocol/authentication_method.cc View 2 chunks +22 lines, -0 lines 0 comments Download
M remoting/protocol/me2me_host_authenticator_factory.h View 1 chunk +0 lines, -11 lines 0 comments Download
M remoting/protocol/me2me_host_authenticator_factory.cc View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
simonmorris
ptal
8 years, 4 months ago (2012-05-04 17:12:38 UTC) #1
alexeypa (please no reviews)
lgtm
8 years, 4 months ago (2012-05-04 17:53:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonmorris@chromium.org/10317021/1
8 years, 4 months ago (2012-05-04 17:56:55 UTC) #3
commit-bot: I haz the power
Try job failure for 10317021-1 (retry) on win for step "runhooks". It's a second try, ...
8 years, 4 months ago (2012-05-04 18:17:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonmorris@chromium.org/10317021/4004
8 years, 4 months ago (2012-05-05 00:51:57 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-05-05 03:07:43 UTC) #6
Change committed as 135522

Powered by Google App Engine
This is Rietveld 408576698