Issue 1031683002: Fix authenticator.js history.replaceState call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1031683002: Fix authenticator.js history.replaceState call. (Closed)

Created:
5 years, 9 months ago by xiyuan

Modified:
5 years, 9 months ago

Reviewers:
noms (inactive)

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Fix authenticator.js history.replaceState call. BUG=469591 Committed: https://crrev.com/6ae60dfe75791bbc0cdd26d7fe09c49d665c8e52 Cr-Commit-Position: refs/heads/master@{#321798}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/resources/gaia_auth_host/authenticator.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (2 generated)

xiyuan

This now becomes a RB bug. :) Could you help to review this? Thanks.

5 years, 9 months ago (2015-03-23 16:10:56 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031683002/1

5 years, 9 months ago (2015-03-23 17:11:54 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-23 17:16:24 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/6ae60dfe75791bbc0cdd26d7fe09c49d665c8e52
Cr-Commit-Position: refs/heads/master@{#321798}