Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 103163009: Fix the bug that virtual keyboard window doesn't work. (Closed)

Created:
7 years ago by Shu Chen
Modified:
7 years ago
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, bshe, kevers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix the bug that virtual keyboard window doesn't work. BUG=329756 TEST=Verified in sandbox. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242064

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/browser/ui/ash/ash_keyboard_controller_proxy.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Shu Chen
Biao/Kevin, mind take a look? Thanks, Shu
7 years ago (2013-12-19 03:43:36 UTC) #1
Shu Chen
Both Biao and Kevin are in vacation. Peter/James, can you please help to review this ...
7 years ago (2013-12-19 04:00:42 UTC) #2
James Cook
LGTM but you might want to add a comment as to why the opacity has ...
7 years ago (2013-12-19 17:30:21 UTC) #3
Peter Kasting
I'm not a good reviewer here, but I agree with James' comment that this really ...
7 years ago (2013-12-19 22:36:15 UTC) #4
Shu Chen
Thanks for your reviews. I actually don't know the root cause of why calling Hide ...
7 years ago (2013-12-20 08:09:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/103163009/10001
7 years ago (2013-12-20 08:10:37 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-20 12:06:01 UTC) #7
Message was sent while issue was closed.
Change committed as 242064

Powered by Google App Engine
This is Rietveld 408576698