Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1031623002: Script streaming: add UMA for tracking the reason why we don't stream. (Closed)

Created:
5 years, 9 months ago by marja
Modified:
5 years, 9 months ago
Reviewers:
haraken, Ilya Sherman
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Script streaming: add UMA for tracking the reason why we don't stream. This will make it possible to see whether it's possible to stream more scripts than currently (and what needs to be done to do that). Suspecting that the biggest reason for not streaming is that the resource is already loaded (which is OK, no actions needed there). BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192362

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -11 lines) Patch
M Source/bindings/core/v8/ScriptStreamer.cpp View 9 chunks +24 lines, -11 lines 1 comment Download

Messages

Total messages: 9 (3 generated)
marja
haraken@, ptal. Some "streaming version 2" stuff. (Or rather, investigating whether there's potential for enhancements... ...
5 years, 9 months ago (2015-03-23 12:23:54 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-23 13:17:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031623002/1
5 years, 9 months ago (2015-03-23 13:21:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=192362
5 years, 9 months ago (2015-03-23 14:41:55 UTC) #6
Ilya Sherman
https://codereview.chromium.org/1031623002/diff/1/Source/bindings/core/v8/ScriptStreamer.cpp File Source/bindings/core/v8/ScriptStreamer.cpp (right): https://codereview.chromium.org/1031623002/diff/1/Source/bindings/core/v8/ScriptStreamer.cpp#newcode496 Source/bindings/core/v8/ScriptStreamer.cpp:496: blink::Platform::current()->histogramEnumeration(kNotStreamingReasonHistogramName, 3, 8); Could you please use enumerated constant ...
5 years, 9 months ago (2015-03-23 22:14:44 UTC) #8
marja
5 years, 9 months ago (2015-03-24 15:38:46 UTC) #9
Message was sent while issue was closed.
Will do (in the near future). At some point I thought I'd just remove this UMA
after being done w/ the analysis, but actually, why not keep it in place for
monitoring that streaming keeps running...

According to the first numbers (only 3000 samples), ~50% are "script already
loaded" (as expected) and the other ~50% is "script too small", so, looks like
streaming works as expected all in all. Other reasons are negligible.

Powered by Google App Engine
This is Rietveld 408576698