Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 1031593003: IDL: Add support for serializer definitions (Closed)

Created:
5 years, 9 months ago by Jens Widell
Modified:
5 years, 9 months ago
Reviewers:
haraken, bashi
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IDL: Add support for serializer definitions A serializer definition is output as a 'Serializer' production, with either no children, an 'Operation' child, or a 'Map'/'List' child. The production has an attribute named 'ATTRIBUTE' in the serializer = identifier; form (and no children), and the 'Map'/'List' productions have attributes named 'GETTER', 'INHERIT' and 'ATTRIBUTES', where the latter is a list of the attributes named in the definition. BUG=469650 Committed: https://crrev.com/577bccbad01ca22a55df7d6c828459e39616d8fd Cr-Commit-Position: refs/heads/master@{#321780}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -1 line) Patch
M tools/idl_parser/idl_parser.py View 1 2 3 2 chunks +69 lines, -1 line 0 comments Download
M tools/idl_parser/test_parser/interface_web.idl View 1 2 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Jens Widell
PTAL
5 years, 9 months ago (2015-03-23 11:42:56 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-23 13:30:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031593003/60001
5 years, 9 months ago (2015-03-23 14:42:06 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-23 15:43:46 UTC) #6
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/577bccbad01ca22a55df7d6c828459e39616d8fd Cr-Commit-Position: refs/heads/master@{#321780}
5 years, 9 months ago (2015-03-23 15:44:36 UTC) #7
bashi
5 years, 9 months ago (2015-03-24 00:22:59 UTC) #8
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698