Remove inheritance of designMode attribute.

Remove inheritance of designMode attribute.

This matches the behavior of IE and Firefox, and conveniently removes a
problematic bit of code for OOPI.

BUG=444927
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192658

[dcheng, 2015-03-23 12:49:12]

dcheng@chromium.org changed reviewers:
+ yosin@chromium.org

[dcheng, 2015-03-24 01:43:01]

yosin@, do you mind reviewing this?

[dcheng, 2015-03-24 01:43:27]

(I need to rebaseline several layout tests, but I wanted to make sure that the
approach seems fine before I do that)

[dcheng, 2015-03-24 01:49:46]

More details: IE has the funny inherit value for the attribute, but (as far as I
can tell) subframes don't actually become editable.

[dcheng, 2015-03-24 04:05:58]

Actually I think this needs an intent, so I've sent one to the blink mailing
list, and I'll wait for the public feedback first.

[yosin_UTC9, 2015-03-24 05:18:38]

lgtm

https://codereview.chromium.org/1031543003/diff/1/Source/core/dom/Document.cpp
File Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/1031543003/diff/1/Source/core/dom/Document.cp...
Source/core/dom/Document.cpp:4330: setNeedsStyleRecalc(SubtreeStyleChange,
StyleChangeReasonForTracing::create(StyleChangeReason::DesignMode));
nit: It is better to set style recalc when state was actually changed, e.g.

auto newDesignMode = m_desginMode;
if (equalIgnoringCase(value, "on"))
  newDesignMode = true;
else if (equalIgnoringCase(value, "off")
  newDesignMode = false;
if (newDesignMode == m_desginMode)
  return;
m_designMode = newDesignMode;
setNeedStyleRecalc(...);

[dcheng, 2015-03-26 01:53:14]

dcheng@chromium.org changed reviewers:
+ chrishtr@chromium.org

[dcheng, 2015-03-26 01:53:14]

PTAL.

Also, +chrishtr@ to see if he wanted something more involved for the usage
counter or if this is fine. I didn't implement esprehn@'s suggestion (only count
instances where designMode = "on" gets inherited) since that would require
adding back in the problematic site isolation assumptions that I'm trying to
remove.

https://codereview.chromium.org/1031543003/diff/1/Source/core/dom/Document.cpp
File Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/1031543003/diff/1/Source/core/dom/Document.cp...
Source/core/dom/Document.cpp:4330: setNeedsStyleRecalc(SubtreeStyleChange,
StyleChangeReasonForTracing::create(StyleChangeReason::DesignMode));
On 2015/03/24 at 05:18:38, Yosi_UTC9 wrote:
> nit: It is better to set style recalc when state was actually changed, e.g.
> 
> auto newDesignMode = m_desginMode;
> if (equalIgnoringCase(value, "on"))
>   newDesignMode = true;
> else if (equalIgnoringCase(value, "off")
>   newDesignMode = false;
> if (newDesignMode == m_desginMode)
>   return;
> m_designMode = newDesignMode;
> setNeedStyleRecalc(...);

Done.

[chrishtr, 2015-03-26 19:57:17]

UseCounter LGTM. Thanks!

[dcheng, 2015-03-27 03:38:47]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2015-03-27 03:38:47]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/1031543003/#ps20001
(title: "Address review comments, add usage counter, rebase tests, rebase to
ToT")

[commit-bot: I haz the power, 2015-03-27 03:39:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1031543003/20001

[commit-bot: I haz the power, 2015-03-27 08:27:15]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192658