ui/views/controls/textfield/textfield_model.h - Issue 1031533002: Supports the invisible underline for native input fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/textfield/textfield_model.h

Issue 1031533002: Supports the invisible underline for native input fields. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: revised per comments and fixed test failures. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/base/ime/composition_text.cc ('K') | « ui/views/controls/textfield/textfield.cc ('k') | ui/views/controls/textfield/textfield_model.cc » ('j') | ui/views/controls/textfield/textfield_model.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/controls/textfield/textfield_model.h

diff --git a/ui/views/controls/textfield/textfield_model.h b/ui/views/controls/textfield/textfield_model.h

index 6ae3398ee466316ca48675ab7e70bae9f45f784b..89c84a0227c6fa70e4dbd0ad5b9dfdf5876d0b2a 100644

--- a/ui/views/controls/textfield/textfield_model.h

+++ b/ui/views/controls/textfield/textfield_model.h

@@ -267,6 +267,9 @@ class VIEWS_EXPORT TextfieldModel {

// The stylized text, cursor, selection, and the visual layout model.

scoped_ptr<gfx::RenderText> render_text_;

+ // The composition range.

+ gfx::Range composition_range_;

typedef std::list<internal::Edit*> EditHistory;

EditHistory edit_history_;