Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 103153002: Disable page_cycler.typical_25 on windows, and session_restore.cold.typical_25 on linux. (Closed)

Created:
7 years ago by shatch
Modified:
7 years ago
Reviewers:
tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Disable page_cycler.typical_25 on windows, and session_restore.cold.typical_25 on linux. NOTRY=true BUG=273986, 325479 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238516

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changes from review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M tools/perf/benchmarks/page_cycler.py View 1 2 chunks +4 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/session_restore.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
shatch
7 years ago (2013-12-03 22:39:55 UTC) #1
tonyg
lgtm Thanks! https://codereview.chromium.org/103153002/diff/1/tools/perf/benchmarks/page_cycler.py File tools/perf/benchmarks/page_cycler.py (right): https://codereview.chromium.org/103153002/diff/1/tools/perf/benchmarks/page_cycler.py#newcode108 tools/perf/benchmarks/page_cycler.py:108: enabled = not sys.platform.startswith('win') Please mention crbug.com/273986 ...
7 years ago (2013-12-03 22:44:12 UTC) #2
shatch
https://codereview.chromium.org/103153002/diff/1/tools/perf/benchmarks/page_cycler.py File tools/perf/benchmarks/page_cycler.py (right): https://codereview.chromium.org/103153002/diff/1/tools/perf/benchmarks/page_cycler.py#newcode108 tools/perf/benchmarks/page_cycler.py:108: enabled = not sys.platform.startswith('win') On 2013/12/03 22:44:12, tonyg wrote: ...
7 years ago (2013-12-03 22:46:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonhatch@chromium.org/103153002/20001
7 years ago (2013-12-04 00:08:43 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-04 01:12:35 UTC) #5
Message was sent while issue was closed. 
Change committed as 238516

Powered by Google App Engine
This is Rietveld 408576698