courgette/disassembler.cc - Issue 1031513002: Robust ELF header parsing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: courgette/disassembler.cc

Issue 1031513002: Robust ELF header parsing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Replace uint32_t with Elf32_Off and add CHECK in ReduceLength Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: courgette/disassembler.cc

diff --git a/courgette/disassembler.cc b/courgette/disassembler.cc

index 1b7b16e225d0c8fd03acfb70321a901a5bf60da0..f146b4eb71146b91fe4252061762146bba28889c 100644

--- a/courgette/disassembler.cc

+++ b/courgette/disassembler.cc

@@ -125,8 +125,9 @@ bool Disassembler::Bad(const char* reason) {

}

void Disassembler::ReduceLength(size_t reduced_length) {

- if (reduced_length < length_)

- length_ = reduced_length;

+ CHECK_LE(reduced_length, length_);

+ length_ = reduced_length;

+ end_ = start_ + length_;

}

} // namespace courgette

« no previous file with comments | « courgette/disassembler.h ('k') | courgette/disassembler_elf_32.h » ('j') | no next file with comments »