Issue 103143005: WinAura: don't create tooltip on hide

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 103143005: WinAura: don't create tooltip on hide (Closed)

Created:
7 years ago by cpu_(ooo_6.6-7.5)

Modified:
7 years ago

Reviewers:
sadrul

CC:
chromium-reviews, tfarina, ben+corewm_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

WinAura: don't create tooltip on hide The tooltip code is executed via timers from TooltipController::UpdateIfRequired() Which say a browser startup with no user intervention creates the tooltip window only for the purposes of hiding it. This fires in Ash on Windows creating a tooltip window in the wrong side, it is hidden but it is something we want to avoid. BUG=none TBR=sadrul Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241139

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	ui/views/corewm/tooltip_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/103143005/1

7 years ago (2013-12-14 00:27:34 UTC) #2

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=184495

7 years ago (2013-12-14 03:51:46 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/103143005/1

7 years ago (2013-12-17 00:34:46 UTC) #5

Message was sent while issue was closed.

Change committed as 241139

Expand Messages | Collapse Messages