Update webrtc/libjingle 5268:5288.

Update webrtc/libjingle 5268:5301.

R=grunell@chromium.org, mallinath@chromium.org, sergeyu@chromium.org, wjia@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241095

[Henrik Grunell, 2013-12-13 19:26:38]

LGTM on DEPS and content/renderer/media/*.

[Henrik Grunell, 2013-12-13 19:27:22]

On 2013/12/13 19:26:38, Henrik Grunell wrote:
> LGTM on DEPS and content/renderer/media/*.

Note that you need and owner of content/renderer/media/*.

[Ronghua Wu (Left Chromium), 2013-12-13 19:28:16]

+wjia for content

[wjia(left Chromium), 2013-12-13 19:36:13]

content media lgtm. You might need owner for content p2p.

[Niklas Enbom, 2013-12-13 21:19:40]

Wait with this one, need to add one WebRTC fix to this one.
On 2013/12/13 19:36:13, wjia wrote:
> content media lgtm. You might need owner for content p2p.

[Ronghua Wu (Left Chromium), 2013-12-13 22:28:29]

Waiting for Turaj's confirm.

Sergey, need your approval on jingle and remoteing.

[Ronghua Wu (Left Chromium), 2013-12-13 23:08:46]

+turaj

[Sergey Ulanov, 2013-12-13 23:10:12]

lgtm

[Mallinath (Gone from Chromium), 2013-12-15 18:46:16]

On 2013/12/13 23:10:12, Sergey Ulanov wrote:
> lgtm

lgtm

[Mallinath (Gone from Chromium), 2013-12-16 14:04:55]

https://codereview.chromium.org/103143004/diff/1/content/renderer/p2p/ipc_soc...
File content/renderer/p2p/ipc_socket_factory.cc (right):

https://codereview.chromium.org/103143004/diff/1/content/renderer/p2p/ipc_soc...
content/renderer/p2p/ipc_socket_factory.cc:396: talk_base::CreatePacketTime(0));
sync to the latest and uncomment |packet_time| which is present in latest code
and pass |packet_time| as part of the argument list.

[Ronghua Wu (Left Chromium), 2013-12-16 16:56:56]

https://codereview.chromium.org/103143004/diff/1/content/renderer/p2p/ipc_soc...
File content/renderer/p2p/ipc_socket_factory.cc (right):

https://codereview.chromium.org/103143004/diff/1/content/renderer/p2p/ipc_soc...
content/renderer/p2p/ipc_socket_factory.cc:396: talk_base::CreatePacketTime(0));
On 2013/12/16 14:04:56, mallinath2 wrote:
> sync to the latest and uncomment |packet_time| which is present in latest code
> and pass |packet_time| as part of the argument list.

Done.

[Mallinath (Gone from Chromium), 2013-12-16 17:00:55]

https://codereview.chromium.org/103143004/diff/20001/content/renderer/p2p/ipc...
File content/renderer/p2p/ipc_socket_factory.cc (right):

https://codereview.chromium.org/103143004/diff/20001/content/renderer/p2p/ipc...
content/renderer/p2p/ipc_socket_factory.cc:398: timestamp);
SignalReadPacket takes PacketTime as argument, not TimeTicks. So you need to
just uncomment
talk_base::PacketTime packet_time(timestamp.ToInternalValue(), 0); and remove
TODO.

Thanks

[Ronghua Wu (Left Chromium), 2013-12-17 00:41:02]

https://codereview.chromium.org/103143004/diff/20001/content/renderer/p2p/ipc...
File content/renderer/p2p/ipc_socket_factory.cc (right):

https://codereview.chromium.org/103143004/diff/20001/content/renderer/p2p/ipc...
content/renderer/p2p/ipc_socket_factory.cc:398: timestamp);
On 2013/12/16 17:00:55, mallinath2 wrote:
> SignalReadPacket takes PacketTime as argument, not TimeTicks. So you need to
> just uncomment
> talk_base::PacketTime packet_time(timestamp.ToInternalValue(), 0); and remove
> TODO.
> 
> Thanks

Yea, I realized that and done in the 3rd patch.

[Ronghua Wu (Left Chromium), 2013-12-17 01:52:33]

The tree remains closed since this is ready for commit. Will check back
tonight. Otherwise will need to do it tomorrow morning.


On Mon, Dec 16, 2013 at 4:41 PM, <ronghuawu@chromium.org> wrote:

>
> https://codereview.chromium.org/103143004/diff/20001/
> content/renderer/p2p/ipc_socket_factory.cc
> File content/renderer/p2p/ipc_socket_factory.cc (right):
>
> https://codereview.chromium.org/103143004/diff/20001/
> content/renderer/p2p/ipc_socket_factory.cc#newcode398
> content/renderer/p2p/ipc_socket_factory.cc:398: timestamp);
> On 2013/12/16 17:00:55, mallinath2 wrote:
>
>> SignalReadPacket takes PacketTime as argument, not TimeTicks. So you
>>
> need to
>
>> just uncomment
>> talk_base::PacketTime packet_time(timestamp.ToInternalValue(), 0); and
>>
> remove
>
>> TODO.
>>
>
>  Thanks
>>
>
> Yea, I realized that and done in the 3rd patch.
>
> https://codereview.chromium.org/103143004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ronghua Wu (Left Chromium), 2013-12-17 02:02:56]

Committed patchset #3 manually as r241095 (presubmit successful).