Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1031423002: Add mixedtextblob gm and a simple bench (Closed)

Created:
5 years, 9 months ago by joshua.litt
Modified:
5 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : adding textblob gms and bench #

Patch Set 3 : teak #

Patch Set 4 : cleanup #

Patch Set 5 : more #

Patch Set 6 : tweak #

Total comments: 4

Patch Set 7 : tidy #

Patch Set 8 : mac warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -7 lines) Patch
A bench/TextBlobBench.cpp View 1 2 3 4 5 6 1 chunk +71 lines, -0 lines 0 comments Download
A gm/mixedtextblobs.cpp View 1 2 3 4 5 6 7 1 chunk +195 lines, -0 lines 0 comments Download
M gyp/bench.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrAtlasTextContext.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 2 3 4 9 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
joshualitt
ptal
5 years, 8 months ago (2015-04-03 13:40:53 UTC) #3
bsalomon
lgtm. https://codereview.chromium.org/1031423002/diff/90001/bench/TextBlobBench.cpp File bench/TextBlobBench.cpp (right): https://codereview.chromium.org/1031423002/diff/90001/bench/TextBlobBench.cpp#newcode49 bench/TextBlobBench.cpp:49: virtual const char* onGetName() { -virtual +override (same ...
5 years, 8 months ago (2015-04-03 14:33:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031423002/110001
5 years, 8 months ago (2015-04-03 14:40:45 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/349)
5 years, 8 months ago (2015-04-03 14:45:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031423002/130001
5 years, 8 months ago (2015-04-03 14:53:46 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 15:07:31 UTC) #13
Message was sent while issue was closed.
Committed patchset #8 (id:130001) as
https://skia.googlesource.com/skia/+/eef5b3eb12d5aaf55f43762110af250c79cb0a45

Powered by Google App Engine
This is Rietveld 408576698