Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 1031413005: Fix NPE in ApplicationStatus. (Closed)

Created:
5 years, 9 months ago by maxbogue
Modified:
5 years, 9 months ago
Reviewers:
nyquist, Yaron
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix NPE in ApplicationStatus. The return line being outside the synchronized block allowed the cached state to be reset to null before it was calculated. BUG=470966 Committed: https://crrev.com/3b8ad9af169861a9dce1b1e4ee3644a9ec4daab4 Cr-Commit-Position: refs/heads/master@{#322479}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M base/android/java/src/org/chromium/base/ApplicationStatus.java View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
maxbogue
5 years, 9 months ago (2015-03-26 21:19:34 UTC) #2
nyquist
lgtm
5 years, 9 months ago (2015-03-26 21:30:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031413005/1
5 years, 9 months ago (2015-03-26 21:30:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 22:03:16 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3b8ad9af169861a9dce1b1e4ee3644a9ec4daab4 Cr-Commit-Position: refs/heads/master@{#322479}
5 years, 9 months ago (2015-03-26 22:04:26 UTC) #7
Yaron
lgtm
5 years, 9 months ago (2015-03-27 01:18:13 UTC) #9
Yaron
5 years, 9 months ago (2015-03-27 01:18:30 UTC) #10
Message was sent while issue was closed.
On 2015/03/27 01:18:13, Yaron wrote:
> lgtm

(err meant to lgtm the branch one)

Powered by Google App Engine
This is Rietveld 408576698