Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1588)

Unified Diff: chrome/browser/devtools/devtools_targets_ui.cc

Issue 1031393002: [DevTools] Remove unused messages (Chromium side) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/devtools_targets_ui.h ('k') | chrome/browser/devtools/devtools_ui_bindings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_targets_ui.cc
diff --git a/chrome/browser/devtools/devtools_targets_ui.cc b/chrome/browser/devtools/devtools_targets_ui.cc
index b204b0567871bc2c03aa2740aa9c64dbe2cfdd3f..f5aa559c3a7da2c10e2862734dd31b8c9189021d 100644
--- a/chrome/browser/devtools/devtools_targets_ui.cc
+++ b/chrome/browser/devtools/devtools_targets_ui.cc
@@ -269,9 +269,7 @@ class AdbTargetsUIHandler
AdbTargetsUIHandler(const Callback& callback, Profile* profile);
~AdbTargetsUIHandler() override;
- void Open(const std::string& browser_id,
- const std::string& url,
- const DevToolsTargetsUIHandler::TargetCallback&) override;
+ void Open(const std::string& browser_id, const std::string& url) override;
scoped_refptr<content::DevToolsAgentHost> GetBrowserAgentHost(
const std::string& browser_id) override;
@@ -305,17 +303,11 @@ AdbTargetsUIHandler::~AdbTargetsUIHandler() {
android_bridge_->RemoveDeviceListListener(this);
}
-static void CallOnTarget(
- const DevToolsTargetsUIHandler::TargetCallback& callback,
- DevToolsAndroidBridge* bridge,
- scoped_refptr<DevToolsAndroidBridge::RemotePage> page) {
- callback.Run(bridge && page.get() ? bridge->CreatePageTarget(page) : nullptr);
+static void NoOp(scoped_refptr<DevToolsAndroidBridge::RemotePage> page) {
}
-void AdbTargetsUIHandler::Open(
- const std::string& browser_id,
- const std::string& url,
- const DevToolsTargetsUIHandler::TargetCallback& callback) {
+void AdbTargetsUIHandler::Open(const std::string& browser_id,
+ const std::string& url) {
RemoteBrowsers::iterator it = remote_browsers_.find(browser_id);
if (it == remote_browsers_.end())
return;
@@ -323,7 +315,7 @@ void AdbTargetsUIHandler::Open(
android_bridge_->OpenRemotePage(
it->second,
url,
- base::Bind(&CallOnTarget, callback, android_bridge_));
+ base::Bind(&NoOp));
}
scoped_refptr<content::DevToolsAgentHost>
@@ -440,9 +432,7 @@ DevToolsTargetImpl* DevToolsTargetsUIHandler::GetTarget(
}
void DevToolsTargetsUIHandler::Open(const std::string& browser_id,
- const std::string& url,
- const TargetCallback& callback) {
- callback.Run(NULL);
+ const std::string& url) {
}
scoped_refptr<content::DevToolsAgentHost>
« no previous file with comments | « chrome/browser/devtools/devtools_targets_ui.h ('k') | chrome/browser/devtools/devtools_ui_bindings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698