Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1031393002: [DevTools] Remove unused messages (Chromium side) (Closed)

Created:
5 years, 8 months ago by vkuzkokov
Modified:
5 years, 8 months ago
Reviewers:
dgozman
CC:
chromium-reviews, aandrey+blink_chromium.org, yurys, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove unused messages (Chromium side) BUG= TBR=tsepez@chromium.org,pfeldman@chromium.org Committed: https://crrev.com/d49c9e1844e2497e9d38c06f131004d9f5bf3249 Cr-Commit-Position: refs/heads/master@{#322399}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -64 lines) Patch
M chrome/browser/devtools/devtools_embedder_message_dispatcher.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/devtools/devtools_embedder_message_dispatcher.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/devtools/devtools_targets_ui.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/devtools/devtools_targets_ui.cc View 4 chunks +6 lines, -16 lines 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.cc View 3 chunks +0 lines, -31 lines 0 comments Download
M chrome/browser/ui/webui/inspect_ui.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
vkuzkokov
5 years, 8 months ago (2015-03-26 15:41:57 UTC) #2
dgozman
lgtm
5 years, 8 months ago (2015-03-26 15:46:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031393002/1
5 years, 8 months ago (2015-03-26 15:46:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/52089)
5 years, 8 months ago (2015-03-26 15:53:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031393002/1
5 years, 8 months ago (2015-03-26 15:55:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-26 16:38:46 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-03-26 16:40:26 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d49c9e1844e2497e9d38c06f131004d9f5bf3249
Cr-Commit-Position: refs/heads/master@{#322399}

Powered by Google App Engine
This is Rietveld 408576698