Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1031293005: Files.app: Do not run thumbnail fetch during directory scan. (Closed)

Created:
5 years, 9 months ago by yawano
Modified:
5 years, 9 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Do not run thumbnail fetch during directory scan. In order not to block IO of directory scan by IO of thumbnail fetch, do not run thumbnail fetch when directory scan is running. BUG=470462 TEST=out/Release/browser_tests --gtest_filter=FileManagerJsTest.ListThumbnailLoader Committed: https://crrev.com/ee41ade513464f548961a22e313a6177558adcce Cr-Commit-Position: refs/heads/master@{#322330}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -8 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js View 5 chunks +28 lines, -6 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/list_thumbnail_loader_unittest.js View 3 chunks +32 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
yawano
PTAL. Thank you!
5 years, 9 months ago (2015-03-26 05:24:35 UTC) #2
fukino
lgtm. Thanks!
5 years, 9 months ago (2015-03-26 05:46:17 UTC) #3
yawano
On 2015/03/26 05:46:17, fukino wrote: > lgtm. Thanks! Thank you!
5 years, 9 months ago (2015-03-26 05:46:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031293005/1
5 years, 9 months ago (2015-03-26 05:47:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 05:53:57 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 05:55:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee41ade513464f548961a22e313a6177558adcce
Cr-Commit-Position: refs/heads/master@{#322330}

Powered by Google App Engine
This is Rietveld 408576698