Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 1031293004: Fix ctrl+shift+p for PDF (Closed)

Created:
5 years, 9 months ago by raymes
Modified:
5 years, 9 months ago
Reviewers:
Sam McNally
CC:
chromium-reviews, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ctrl+shift+p for PDF Currentl we are intercepting ctrl+p on PDF to print, which is interfering with ctrl+shift+p. There is no need to intercept either of these commands anymore, the default handling should work correctly. BUG=466600 Committed: https://crrev.com/78b9904963a16d99dbb40e30d9a3dac6b25e6285 Cr-Commit-Position: refs/heads/master@{#322328}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M chrome/browser/resources/pdf/pdf.js View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
raymes
5 years, 9 months ago (2015-03-26 04:34:48 UTC) #2
Sam McNally
lgtm
5 years, 9 months ago (2015-03-26 04:36:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031293004/1
5 years, 9 months ago (2015-03-26 04:38:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 05:33:55 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 05:34:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78b9904963a16d99dbb40e30d9a3dac6b25e6285
Cr-Commit-Position: refs/heads/master@{#322328}

Powered by Google App Engine
This is Rietveld 408576698