Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1180)

Unified Diff: components/enhanced_bookmarks/test_image_store.h

Issue 1031293002: Fix crashes due to gfx::Image unsafe thread passing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unnecessary Pass() Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/enhanced_bookmarks/test_image_store.h
diff --git a/components/enhanced_bookmarks/test_image_store.h b/components/enhanced_bookmarks/test_image_store.h
index 460a285c837ba736f6d03665ed518615524e19de..e74d25b77892fa7998a9c05b2cd7c1f5acc6c819 100644
--- a/components/enhanced_bookmarks/test_image_store.h
+++ b/components/enhanced_bookmarks/test_image_store.h
@@ -14,10 +14,12 @@ class TestImageStore : public ImageStore {
public:
TestImageStore();
bool HasKey(const GURL& page_url) override;
- void Insert(const GURL& page_url,
- const enhanced_bookmarks::ImageRecord& image) override;
+ void Insert(
+ const GURL& page_url,
+ scoped_refptr<enhanced_bookmarks::ImageRecord> image_record) override;
void Erase(const GURL& page_url) override;
- enhanced_bookmarks::ImageRecord Get(const GURL& page_url) override;
+ scoped_refptr<enhanced_bookmarks::ImageRecord> Get(
+ const GURL& page_url) override;
gfx::Size GetSize(const GURL& page_url) override;
void GetAllPageUrls(std::set<GURL>* urls) override;
void ClearAll() override;
@@ -27,7 +29,8 @@ class TestImageStore : public ImageStore {
~TestImageStore() override;
private:
- typedef std::map<const GURL, enhanced_bookmarks::ImageRecord> ImageMap;
+ typedef std::map<const GURL, scoped_refptr<enhanced_bookmarks::ImageRecord>>
+ ImageMap;
ImageMap store_;
DISALLOW_COPY_AND_ASSIGN(TestImageStore);
« no previous file with comments | « components/enhanced_bookmarks/persistent_image_store.cc ('k') | components/enhanced_bookmarks/test_image_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698