components/enhanced_bookmarks/persistent_image_store.h - Issue 1031293002: Fix crashes due to gfx::Image unsafe thread passing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/enhanced_bookmarks/persistent_image_store.h

Issue 1031293002: Fix crashes due to gfx::Image unsafe thread passing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unnecessary Pass() Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/enhanced_bookmarks/image_store_unittest.cc ('k') | components/enhanced_bookmarks/persistent_image_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/enhanced_bookmarks/persistent_image_store.h

diff --git a/components/enhanced_bookmarks/persistent_image_store.h b/components/enhanced_bookmarks/persistent_image_store.h

index 5a0c41d596297ec36a8972a8f23d0be9023700ff..d6f12f3529c35f7722de73334d964ac8aa3a787d 100644

--- a/components/enhanced_bookmarks/persistent_image_store.h

+++ b/components/enhanced_bookmarks/persistent_image_store.h

@@ -20,9 +20,10 @@ class PersistentImageStore : public ImageStore {

explicit PersistentImageStore(const base::FilePath& path);

bool HasKey(const GURL& page_url) override;

void Insert(const GURL& page_url,

- const enhanced_bookmarks::ImageRecord& image) override;

+ scoped_refptr<enhanced_bookmarks::ImageRecord> image) override;

void Erase(const GURL& page_url) override;

- enhanced_bookmarks::ImageRecord Get(const GURL& page_url) override;

+ scoped_refptr<enhanced_bookmarks::ImageRecord> Get(

+ const GURL& page_url) override;

gfx::Size GetSize(const GURL& page_url) override;

void GetAllPageUrls(std::set<GURL>* urls) override;

void ClearAll() override;

« no previous file with comments | « components/enhanced_bookmarks/image_store_unittest.cc ('k') | components/enhanced_bookmarks/persistent_image_store.cc » ('j') | no next file with comments »