Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: components/enhanced_bookmarks/image_store.h

Issue 1031293002: Fix crashes due to gfx::Image unsafe thread passing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unnecessary Pass() Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/enhanced_bookmarks/image_record.cc ('k') | components/enhanced_bookmarks/image_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/enhanced_bookmarks/image_store.h
diff --git a/components/enhanced_bookmarks/image_store.h b/components/enhanced_bookmarks/image_store.h
index f4c63fa7c7194f665557b28ebcf2de3e65f6cac8..e92ba5a472bcd7055a90e8b02396834fb84e60f2 100644
--- a/components/enhanced_bookmarks/image_store.h
+++ b/components/enhanced_bookmarks/image_store.h
@@ -27,8 +27,9 @@ class ImageStore {
// be null indicating that the download of the image at this URL or
// encoding for insertion failed previously. On non-iOS platforms, |image|
// must have exactly one representation with a scale factor of 1.
- virtual void Insert(const GURL& page_url,
- const enhanced_bookmarks::ImageRecord& image_record) = 0;
+ virtual void Insert(
+ const GURL& page_url,
+ scoped_refptr<enhanced_bookmarks::ImageRecord> image_record) = 0;
// Removes an image from the store.
virtual void Erase(const GURL& page_url) = 0;
@@ -38,7 +39,8 @@ class ImageStore {
// image_url where the image was downloaded from or failed to be downloaded
// from. When the image is not empty, the dominant color of the image is also
// filled.
- virtual enhanced_bookmarks::ImageRecord Get(const GURL& page_url) = 0;
+ virtual scoped_refptr<enhanced_bookmarks::ImageRecord> Get(
+ const GURL& page_url) = 0;
// Returns the size of the image stored for this URL or empty size if no
// images are present.
« no previous file with comments | « components/enhanced_bookmarks/image_record.cc ('k') | components/enhanced_bookmarks/image_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698