Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc

Issue 1031293002: Fix crashes due to gfx::Image unsafe thread passing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unnecessary Pass() Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc
diff --git a/chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc b/chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc
index fbbdbda57339952ff69e9015ebc9120ed2e823de..6cd7c65b0a141ade25b82b830d0f1a2658957b22 100644
--- a/chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc
+++ b/chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc
@@ -45,14 +45,14 @@ using enhanced_bookmarks::ImageRecord;
namespace {
void Callback(ScopedJavaGlobalRef<jobject>* j_callback,
- const ImageRecord& image_record) {
+ scoped_refptr<ImageRecord> image_record) {
JNIEnv* env = base::android::AttachCurrentThread();
scoped_ptr<ScopedJavaGlobalRef<jobject> > j_callback_ptr(j_callback);
ScopedJavaLocalRef<jstring> j_url =
- base::android::ConvertUTF8ToJavaString(env, image_record.url.spec());
+ base::android::ConvertUTF8ToJavaString(env, image_record->url.spec());
- SkBitmap bitmap = image_record.image.AsBitmap();
+ SkBitmap bitmap = image_record->image->AsBitmap();
ScopedJavaLocalRef<jobject> j_bitmap;
if (!bitmap.isNull()) {
j_bitmap = gfx::ConvertToJavaBitmap(&bitmap);
« no previous file with comments | « chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.cc ('k') | components/enhanced_bookmarks.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698