chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.h - Issue 1031293002: Fix crashes due to gfx::Image unsafe thread passing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.h

Issue 1031293002: Fix crashes due to gfx::Image unsafe thread passing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Attempt #2 to fix image_store_ios_unittest.mm Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.cc » ('j') | chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.h

diff --git a/chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.h b/chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.h

index 3c73616de344826ce32422d55c01da2fe8795ce6..18185f08f6496af84e81e3f734c43377b3f332ef 100644

--- a/chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.h

+++ b/chrome/browser/enhanced_bookmarks/android/bookmark_image_service_android.h

@@ -50,7 +50,7 @@ class BookmarkImageServiceAndroid : public BookmarkImageService {

bool update_bookmark,

const base::Value* result);

- gfx::Image ResizeImage(gfx::Image image) override;

+ void ResizeImage(scoped_ptr<gfx::Image> *image) override;

content::BrowserContext* browser_context_;

// The script injected in a page to extract image urls.