Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1031263002: Ensure that the DXVA decoder for VP8 and VP9 picks up the path for the HMFT correctly on non WOW64 … (Closed)

Created:
5 years, 9 months ago by ananta
Modified:
5 years, 9 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure that the DXVA decoder for VP8 and VP9 picks up the path for the HMFT correctly on non WOW64 environments The DXVA decoder incorrectly assumes that the ProgramW6432 environment variable exists on vanilla 32 bit Windows OS'es which is not the case. This causes the HMFT load to fail. Fix is to only use the DIR_PROGRAM_FILES6432 directory type for a WOW64 environment which is 32 bit chrome on a 64 bit OS. In the normal case we use the vanilla DIR_PROGRAM_FILES type. BUG=470193 Committed: https://crrev.com/793e7f070633e621b704fcdd930ae01442081b7a Cr-Commit-Position: refs/heads/master@{#322272}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M content/common/gpu/media/dxva_video_decode_accelerator.cc View 1 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ananta
5 years, 9 months ago (2015-03-25 21:09:24 UTC) #2
DaleCurtis
lgtm % nit https://codereview.chromium.org/1031263002/diff/1/content/common/gpu/media/dxva_video_decode_accelerator.cc File content/common/gpu/media/dxva_video_decode_accelerator.cc (right): https://codereview.chromium.org/1031263002/diff/1/content/common/gpu/media/dxva_video_decode_accelerator.cc#newcode945 content/common/gpu/media/dxva_video_decode_accelerator.cc:945: base::win::OSInfo::WOW64_ENABLED) { Indent seems wrong?
5 years, 9 months ago (2015-03-25 22:19:29 UTC) #3
ananta
https://codereview.chromium.org/1031263002/diff/1/content/common/gpu/media/dxva_video_decode_accelerator.cc File content/common/gpu/media/dxva_video_decode_accelerator.cc (right): https://codereview.chromium.org/1031263002/diff/1/content/common/gpu/media/dxva_video_decode_accelerator.cc#newcode945 content/common/gpu/media/dxva_video_decode_accelerator.cc:945: base::win::OSInfo::WOW64_ENABLED) { On 2015/03/25 22:19:28, DaleCurtis wrote: > Indent ...
5 years, 9 months ago (2015-03-25 22:54:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031263002/20001
5 years, 9 months ago (2015-03-25 22:56:26 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-26 00:27:29 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 00:28:01 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/793e7f070633e621b704fcdd930ae01442081b7a
Cr-Commit-Position: refs/heads/master@{#322272}

Powered by Google App Engine
This is Rietveld 408576698