Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 1031253002: Format ONC translation files (Closed)

Created:
5 years, 9 months ago by stevenjb
Modified:
5 years, 9 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Format ONC translation files BUG=None Committed: https://crrev.com/419f2d3d5ed99aed80ef73e1a7e77e4203c3228d Cr-Commit-Position: refs/heads/master@{#322338}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+565 lines, -573 lines) Patch
M chromeos/network/onc/onc_signature.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chromeos/network/onc/onc_signature.cc View 1 1 chunk +358 lines, -349 lines 0 comments Download
M chromeos/network/onc/onc_translation_tables.cc View 7 chunks +164 lines, -169 lines 0 comments Download
M chromeos/network/onc/onc_translator_onc_to_shill.cc View 5 chunks +8 lines, -10 lines 0 comments Download
M chromeos/network/onc/onc_translator_shill_to_onc.cc View 13 chunks +33 lines, -42 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
stevenjb
The Clang checks on these files have been annoying me.
5 years, 9 months ago (2015-03-25 21:12:11 UTC) #2
pneubeck (no reviews)
lgtm
5 years, 9 months ago (2015-03-26 08:23:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031253002/20001
5 years, 9 months ago (2015-03-26 08:23:37 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-26 08:59:45 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 09:00:19 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/419f2d3d5ed99aed80ef73e1a7e77e4203c3228d
Cr-Commit-Position: refs/heads/master@{#322338}

Powered by Google App Engine
This is Rietveld 408576698