Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: net/tools/quic/quic_dispatcher.h

Issue 1031243002: Unify the QUIC dispatcher and make the QuicServer work. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix iOS Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/test_tools/quic_test_utils.cc ('k') | net/tools/quic/quic_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_dispatcher.h
diff --git a/net/tools/quic/quic_dispatcher.h b/net/tools/quic/quic_dispatcher.h
index 2e90bdd7ea573a4bc0160f212a33731409b97dcc..002739d3118b2649011e7e434122b22c2566d675 100644
--- a/net/tools/quic/quic_dispatcher.h
+++ b/net/tools/quic/quic_dispatcher.h
@@ -41,7 +41,8 @@ class ProcessPacketInterface {
};
class QuicDispatcher : public QuicServerSessionVisitor,
- public ProcessPacketInterface {
+ public ProcessPacketInterface,
+ public QuicBlockedWriterInterface {
public:
// Creates per-connection packet writers out of the QuicDispatcher's shared
// QuicPacketWriter. The per-connection writers' IsWriteBlocked() state must
@@ -80,7 +81,8 @@ class QuicDispatcher : public QuicServerSessionVisitor,
~QuicDispatcher() override;
- virtual void Initialize(int fd);
+ // Takes ownership of |writer|.
+ void InitializeWithWriter(QuicPacketWriter* writer);
// Process the incoming packet by creating a new session, passing it to
// an existing session, or passing it to the TimeWaitListManager.
@@ -88,8 +90,8 @@ class QuicDispatcher : public QuicServerSessionVisitor,
const IPEndPoint& client_address,
const QuicEncryptedPacket& packet) override;
- // Called when the socket becomes writable to allow queued writes to happen.
- virtual void OnCanWrite();
+ // Called When the socket becomes writable to allow queued writes to happen.
ramant (doing other things) 2015/03/26 00:01:38 overly overly nit: "Called When" -> "Called when"?
Ryan Hamilton 2015/03/26 03:50:26 Done.
+ void OnCanWrite() override;
// Returns true if there's anything in the blocked writer list.
virtual bool HasPendingWrites() const;
@@ -122,10 +124,6 @@ class QuicDispatcher : public QuicServerSessionVisitor,
void DeleteSessions();
protected:
- // Instantiates a new low-level packet writer. Caller takes ownership of the
- // returned object.
- virtual QuicPacketWriter* CreateWriter(int fd);
-
virtual QuicServerSession* CreateQuicSession(
QuicConnectionId connection_id,
const IPEndPoint& server_address,
« no previous file with comments | « net/quic/test_tools/quic_test_utils.cc ('k') | net/tools/quic/quic_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698