Unify the QUIC dispatcher and make the QuicServer work.

Unify the QUIC dispatcher and make the QuicServer work.

Initialize the QuicDispatcher with a PacketWriter instead of an int fd.
QuicDispatcher::Initialize() used to take an fd which chromium does not make
use of. Instead, it should simply take a PacketWriter* which the caller
should be responsible for creating. Renamed Initialize() to
InitializeWithWriter() to reflect this. Removed the CreateWriter() method
from the QuicDispatcher and moved it to QuicServer.
Merge internal change: 89495510

Committed: https://crrev.com/c99f380cf23683b104ba8fa28265b85abfe69a53
Cr-Commit-Position: refs/heads/master@{#322450}

[Ryan Hamilton, 2015-03-25 21:55:35]

Patchset #2 (id:20001) has been deleted

[Ryan Hamilton, 2015-03-25 22:09:26]

Patchset #2 (id:40001) has been deleted

[Ryan Hamilton, 2015-03-25 22:15:06]

rch@chromium.org changed reviewers:
+ rtenneti@chromium.org

[Ryan Hamilton, 2015-03-25 22:15:07]

Yay!

[Ryan Hamilton, 2015-03-25 22:17:58]

Patchset #3 (id:80001) has been deleted

[ramant (doing other things), 2015-03-26 00:01:39]

lgtm

wow!.

https://codereview.chromium.org/1031243002/diff/100001/net/tools/quic/quic_di...
File net/tools/quic/quic_dispatcher.h (right):

https://codereview.chromium.org/1031243002/diff/100001/net/tools/quic/quic_di...
net/tools/quic/quic_dispatcher.h:93: // Called When the socket becomes writable
to allow queued writes to happen.
overly overly nit: "Called When" -> "Called when"? (I could be wrong and hope it
is not a test for me. :-)).

[Ryan Hamilton, 2015-03-26 03:50:26]

Thanks!

https://codereview.chromium.org/1031243002/diff/100001/net/tools/quic/quic_di...
File net/tools/quic/quic_dispatcher.h (right):

https://codereview.chromium.org/1031243002/diff/100001/net/tools/quic/quic_di...
net/tools/quic/quic_dispatcher.h:93: // Called When the socket becomes writable
to allow queued writes to happen.
On 2015/03/26 00:01:38, ramant wrote:
> overly overly nit: "Called When" -> "Called when"? (I could be wrong and hope
it
> is not a test for me. :-)).

Done.

[Ryan Hamilton, 2015-03-26 14:26:28]

Patchset #6 (id:160001) has been deleted

[Ryan Hamilton, 2015-03-26 15:48:25]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2015-03-26 15:48:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
rtenneti@chromium.org
Link to the patchset: https://codereview.chromium.org/1031243002/#ps180001
(title: "Rebase")

[commit-bot: I haz the power, 2015-03-26 15:48:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1031243002/180001

[commit-bot: I haz the power, 2015-03-26 16:10:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-26 16:10:03]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[Ryan Hamilton, 2015-03-26 16:46:03]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2015-03-26 16:46:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
rtenneti@chromium.org
Link to the patchset: https://codereview.chromium.org/1031243002/#ps220001
(title: "socket_utils.h")

[commit-bot: I haz the power, 2015-03-26 16:46:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1031243002/220001

[commit-bot: I haz the power, 2015-03-26 17:05:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-26 17:05:17]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[Ryan Hamilton, 2015-03-26 17:18:17]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2015-03-26 17:18:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
rtenneti@chromium.org
Link to the patchset: https://codereview.chromium.org/1031243002/#ps240001
(title: "QuicChromeServerDispatchPacketTest")

[commit-bot: I haz the power, 2015-03-26 17:19:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1031243002/240001

[commit-bot: I haz the power, 2015-03-26 19:51:09]

Committed patchset #9 (id:240001)

[commit-bot: I haz the power, 2015-03-26 19:51:39]

Patchset 9 (id:??) landed as
https://crrev.com/c99f380cf23683b104ba8fa28265b85abfe69a53
Cr-Commit-Position: refs/heads/master@{#322450}