Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1031223004: Make climit and jslimit stack limits atomic. (Closed)

Created:
5 years, 9 months ago by ulan
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make climit and jslimit stack limits atomic. This fixes TSAN failure caused by race between: - optimizing compiler thread setting climit - and json parser reading climit in the main thread. BUG= Committed: https://crrev.com/3a814e4c1afc3aee2badad7523b8e8ef6ae80e28 Cr-Commit-Position: refs/heads/master@{#27840}

Patch Set 1 #

Patch Set 2 : Use no-barrier load and store. #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -20 lines) Patch
M src/execution.h View 1 2 chunks +22 lines, -8 lines 0 comments Download
M src/execution.cc View 1 2 4 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
ulan
PTAL
5 years, 9 months ago (2015-03-26 13:15:24 UTC) #2
jochen (gone - plz use gerrit)
Heap::SetStackLimits vs JITted code is still a race, right?
5 years, 9 months ago (2015-03-26 13:17:09 UTC) #3
ulan
On 2015/03/26 13:17:09, jochen wrote: > Heap::SetStackLimits vs JITted code is still a race, right? ...
5 years, 9 months ago (2015-03-26 13:54:33 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-26 14:03:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031223004/40001
5 years, 8 months ago (2015-04-15 10:44:43 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-15 11:37:12 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 11:37:25 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3a814e4c1afc3aee2badad7523b8e8ef6ae80e28
Cr-Commit-Position: refs/heads/master@{#27840}

Powered by Google App Engine
This is Rietveld 408576698