LayoutTests/svg/stroke/stroke-width-rem-type-expected.txt - Issue 1031223003: SVG doesn't recognize rem units

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/svg/stroke/stroke-width-rem-type-expected.txt

Issue 1031223003: SVG doesn't recognize rem units (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/svg/stroke/stroke-width-rem-type.html ('K') | « LayoutTests/svg/stroke/stroke-width-rem-type-expected.png ('k') | Source/core/css/parser/CSSPropertyParser.cpp » ('j') | Source/core/css/parser/CSSPropertyParser.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 layer at (0,0) size 800x600

	2 LayoutView at (0,0) size 800x600

	3 layer at (0,0) size 800x121

	4 LayoutBlockFlow {HTML} at (0,0) size 800x121

	5 LayoutBlockFlow {BODY} at (8,8) size 784x105

	6 LayoutSVGRoot {svg} at (8,8) size 100x100

	7 LayoutSVGPath {line} at (8,8) size 100x100 [stroke={[type=SOLID] [color= #FF0000] [stroke width=32.00]}] [fill={[type=SOLID] [color=#000000]}] [x1=0.00] [y1=0.00] [x2=100.00] [y2=100.00]
	Erik Dahlström (inactive) 2015/03/26 16:11:03 Why not make this an svg reftest instead, as in us Why not make this an svg reftest instead, as in using stroke-width-rem-type-expected.svg? Shanmuga Pandi 2015/03/30 14:40:14 Acknowledged. Show quoted text On 2015/03/26 16:11:03, Erik Dahlström wrote: > Why not make this an svg reftest instead, as in using > stroke-width-rem-type-expected.svg? Acknowledged. Erik Dahlström (inactive) 2015/03/30 15:14:19 Still looks like this uses png references, and I t Show quoted text On 2015/03/30 14:40:14, Shanmuga Pandi wrote: > On 2015/03/26 16:11:03, Erik Dahlström wrote: > > Why not make this an svg reftest instead, as in using > > stroke-width-rem-type-expected.svg? > > Acknowledged. Still looks like this uses png references, and I think that's generally something to avoid. If the expected files were svgs where the rem unit values had been replaced by the expected values expressed in some other unit (em or px), that seems less likely to cause flakiness. Also, fewer binary files in the git tree == good.
	8 LayoutText {#text} at (0,0) size 0x0

OLD	NEW