Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1031203004: To avoid the requirement of defining unnecessary gyp variables for (Closed)

Created:
5 years, 9 months ago by anandc
Modified:
5 years, 9 months ago
Reviewers:
garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

To avoid the requirement of defining unnecessary gyp variables for app-streaming builds, cleanup definition of those variables. Move variables to common include file. Tested by building in a shell with only GYP_DEFINES': 'component=shared_library use_goma=1 BUG= Committed: https://crrev.com/d58d70dbcee9d0537ca74861aefd82e02490b332 Cr-Commit-Position: refs/heads/master@{#322321}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M remoting/app_remoting_webapp_build.gypi View 1 chunk +0 lines, -14 lines 0 comments Download
M remoting/remoting_options.gypi View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
anandc
Hi Gary, PTAL. Thanks.
5 years, 9 months ago (2015-03-25 22:53:04 UTC) #2
garykac
lgtm
5 years, 9 months ago (2015-03-25 22:54:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031203004/1
5 years, 9 months ago (2015-03-25 22:55:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1031203004/1
5 years, 9 months ago (2015-03-26 04:33:36 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 04:48:26 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 04:49:09 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d58d70dbcee9d0537ca74861aefd82e02490b332
Cr-Commit-Position: refs/heads/master@{#322321}

Powered by Google App Engine
This is Rietveld 408576698