Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1031203003: Create per-platform pdfium test suppression files. (Closed)

Created:
5 years, 9 months ago by Tom Sepez
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Create per-platform pdfium test suppression files. This is required now that we have win/mac bots, which may produce different outputs. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/9b5ec50f2c7939fca543aabee029df59f3f7b1a2

Patch Set 1 #

Total comments: 2

Patch Set 2 : Maybe its not linus #

Patch Set 3 : Fix typo in error msg. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -52 lines) Patch
M testing/SUPPRESSIONS View 1 chunk +1 line, -47 lines 0 comments Download
A + testing/SUPPRESSIONS_linux View 1 chunk +1 line, -1 line 0 comments Download
A testing/SUPPRESSIONS_mac View 1 chunk +2 lines, -0 lines 0 comments Download
A testing/SUPPRESSIONS_win View 1 chunk +2 lines, -0 lines 0 comments Download
M testing/tools/run_corpus_tests.py View 1 2 5 chunks +28 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Tom Sepez
Lei, please review. I created a new issue for this approach.
5 years, 9 months ago (2015-03-25 19:54:53 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1031203003/diff/1/testing/tools/run_corpus_tests.py File testing/tools/run_corpus_tests.py (right): https://codereview.chromium.org/1031203003/diff/1/testing/tools/run_corpus_tests.py#newcode54 testing/tools/run_corpus_tests.py:54: os_name = 'linux' Can we explicitly check for ...
5 years, 9 months ago (2015-03-25 20:39:20 UTC) #3
Tom Sepez
https://codereview.chromium.org/1031203003/diff/1/testing/tools/run_corpus_tests.py File testing/tools/run_corpus_tests.py (right): https://codereview.chromium.org/1031203003/diff/1/testing/tools/run_corpus_tests.py#newcode54 testing/tools/run_corpus_tests.py:54: os_name = 'linux' On 2015/03/25 20:39:20, Lei Zhang wrote: ...
5 years, 9 months ago (2015-03-25 20:49:35 UTC) #4
Tom Sepez
5 years, 9 months ago (2015-03-25 20:56:25 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
9b5ec50f2c7939fca543aabee029df59f3f7b1a2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698